-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input Search Dark Mode Friendly #5883
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ashparsh Pandey <[email protected]> Signed-off-by: THEBOSS0369 <[email protected]>
Signed-off-by: l5io <[email protected]> Signed-off-by: THEBOSS0369 <[email protected]>
Signed-off-by: THEBOSS0369 <[email protected]>
7ee7968
to
ae8e3af
Compare
🚀 Preview for commit ae8e3af at: https://66e6cb30f79a9a88c715ccb7--layer5.netlify.app |
@THEBOSS0369, Thank you for your contribution! I'm adding it as an agenda item to the meeting minutes || meeting link. |
src/theme/app/themeStyles.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't want to change theme colors @THEBOSS0369
@THEBOSS0369
|
Also, will you please remove commits not pertinent to the issue ? |
Thanks for sharing this!! 🙂🙂 |
Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js |
Ohhhh, i get it now! I didn't commited those changes but can you tell me how do i remove those commits like do i have to revert back or any other way. |
@vishalvivekm Can you confirm that i have to do Delete File right?? |
Signed-off-by: THEBOSS0369 <[email protected]>
Hey @vishalvivekm ! Please review the changes i made. Also, now the style is similar as the style of searchbox in /news page. |
🚀 Preview for commit b263459 at: https://66ed04ee857b09e66702c1f3--layer5.netlify.app |
@THEBOSS0369 why are we still modifying the themes hex codes? |
Please review the feedback: https://m.youtube.com/watch?v=7ln7cWOHOKo&t=570s |
Signed-off-by: THEBOSS0369 <[email protected]>
Hey @vishalvivekm ! Apologies for late reply. Note the Changes you will see in Searchhox.style.js are the changes which I copied from the official searchbox.style.js to revert back to the original changes from the main branch. Thanks |
🚀 Preview for commit df81b5e at: https://66f5bc40a708be4127521040--layer5.netlify.app |
@THEBOSS0369 any updates? |
Hey @sudhanshutech ! This PR is completed and ready to merge. I had exams which ended today that's why i wasn't able. To join the meeting. |
@THEBOSS0369 there was gatsby upgrade in site please ensure you changes again that it works. |
🚀 Preview for commit defd735 at: https://6706648dbcd8ce273bf87ec6--layer5.netlify.app |
@sudhanshutech ! Everything is working fine i just checked it here are ss. You can also verify these changes on the preview link. |
🚀 Preview for commit df8b948 at: https://67066a3e750f902dccf909cf--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudhanshutech ! The style is same as in Layer5/news section and @vishalvivekm told me to copy the same style. Although I agree that it should be white. If you both agree to that I will change it to white. |
yes please , for light mode it could stay the same but for dark mode a white shade. See if there other icons which do the same like dark shade for light mode and white shade for dark mode and do the same |
Signed-off-by: THEBOSS0369 <[email protected]>
…9/layer5 into dark_theme_search
Signed-off-by: Anuj Kumar Sharma <[email protected]>
Signed-off-by: Anuj Kumar Sharma <[email protected]>
Signed-off-by: Anuj Kumar Sharma <[email protected]>
Signed-off-by: Anuj Kumar Sharma <[email protected]>
@sudhanshutech @vishalvivekm ! I have removed the code from the required searchbox's respective files and add it to the global styles so that in future we don't have to copy paste the whole code and changed the icon's color from black to white as you told me. I hope this PR is in its ending phase now. Here are the Results! |
🚀 Preview for commit 68e48e9 at: https://6710b9a97d9bdaacec91dbd0--layer5.netlify.app |
This PR fixes #5734
Description
I have added some changes so that the input looks like more dark friendly. The changes for style has been done for Intergration Page, Home Page and Blog Page. The style is same as the style in layer5/news page. Below are the ss for the changes made.
Notes for Reviewers
This PR is same as this one #5881 . It is made because of DCO error not resolving.
Signed commits