Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Search Dark Mode Friendly #5883

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

THEBOSS0369
Copy link

@THEBOSS0369 THEBOSS0369 commented Sep 15, 2024

This PR fixes #5734

Description

I have added some changes so that the input looks like more dark friendly. The changes for style has been done for Intergration Page, Home Page and Blog Page. The style is same as the style in layer5/news page. Below are the ss for the changes made.

main page
main page
blog

Notes for Reviewers
This PR is same as this one #5881 . It is made because of DCO error not resolving.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: THEBOSS0369 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 15, 2024

🚀 Preview for commit ae8e3af at: https://66e6cb30f79a9a88c715ccb7--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@THEBOSS0369, Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

I'm adding it as an agenda item to the meeting minutes || meeting link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't want to change theme colors @THEBOSS0369

@vishalvivekm
Copy link
Member

@THEBOSS0369
Sharing the links form our discussion in websites meeting

@vishalvivekm
Copy link
Member

Also, will you please remove commits not pertinent to the issue ?

@THEBOSS0369
Copy link
Author

@THEBOSS0369
Sharing the links form our discussion in websites meeting

Thanks for sharing this!! 🙂🙂

@THEBOSS0369
Copy link
Author

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

@vishalvivekm
Copy link
Member

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits:
Screenshot_20240917-084243

@THEBOSS0369
Copy link
Author

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits:
Screenshot_20240917-084243

Ohhhh, i get it now! I didn't commited those changes but can you tell me how do i remove those commits like do i have to revert back or any other way.

@THEBOSS0369
Copy link
Author

THEBOSS0369 commented Sep 17, 2024

@vishalvivekm Can you confirm that i have to do Delete File right??
image

@THEBOSS0369
Copy link
Author

Hey @vishalvivekm ! Please review the changes i made. Also, now the style is similar as the style of searchbox in /news page.

@l5io
Copy link
Contributor

l5io commented Sep 20, 2024

🚀 Preview for commit b263459 at: https://66ed04ee857b09e66702c1f3--layer5.netlify.app

@vishalvivekm
Copy link
Member

@THEBOSS0369 why are we still modifying the themes hex codes?

@vishalvivekm
Copy link
Member

vishalvivekm commented Sep 22, 2024

@THEBOSS0369 why are we still modifying the themes hex codes?

Please review the feedback: https://m.youtube.com/watch?v=7ln7cWOHOKo&t=570s

@THEBOSS0369
Copy link
Author

THEBOSS0369 commented Sep 25, 2024

Hey @vishalvivekm ! Apologies for late reply.
I got confused and wasn't able to figure out how to do it. Now I have sorted everything, I have added the style for Searchbox in Required Page's ...grid.style.js file and removed the changes from the Themestyles.js and searchbox.style.js .

Note the Changes you will see in Searchhox.style.js are the changes which I copied from the official searchbox.style.js to revert back to the original changes from the main branch.

Thanks

@l5io
Copy link
Contributor

l5io commented Sep 26, 2024

🚀 Preview for commit df81b5e at: https://66f5bc40a708be4127521040--layer5.netlify.app

@sudhanshutech
Copy link
Member

@THEBOSS0369 any updates?

@THEBOSS0369
Copy link
Author

THEBOSS0369 commented Oct 9, 2024

@THEBOSS0369 any updates?

Hey @sudhanshutech ! This PR is completed and ready to merge. I had exams which ended today that's why i wasn't able. To join the meeting.
Thanks

@sudhanshutech
Copy link
Member

@THEBOSS0369 there was gatsby upgrade in site please ensure you changes again that it works.

@l5io
Copy link
Contributor

l5io commented Oct 9, 2024

🚀 Preview for commit defd735 at: https://6706648dbcd8ce273bf87ec6--layer5.netlify.app

@THEBOSS0369
Copy link
Author

@sudhanshutech ! Everything is working fine i just checked it here are ss. You can also verify these changes on the preview link.

image
image
image

@l5io
Copy link
Contributor

l5io commented Oct 9, 2024

🚀 Preview for commit df8b948 at: https://67066a3e750f902dccf909cf--layer5.netlify.app

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ACFBDB30-87EE-48D7-9355-82A42F85CF69}
this search icon should also be a white shade as well

@THEBOSS0369
Copy link
Author

{ACFBDB30-87EE-48D7-9355-82A42F85CF69}
this search icon should also be a white shade as well

@sudhanshutech ! The style is same as in Layer5/news section and @vishalvivekm told me to copy the same style. Although I agree that it should be white. If you both agree to that I will change it to white.

@sudhanshutech
Copy link
Member

sudhanshutech commented Oct 14, 2024

{ACFBDB30-87EE-48D7-9355-82A42F85CF69}
this search icon should also be a white shade as well

@sudhanshutech ! The style is same as in Layer5/news section and @vishalvivekm told me to copy the same style. Although I agree that it should be white. If you both agree to that I will change it to white.

yes please , for light mode it could stay the same but for dark mode a white shade. See if there other icons which do the same like dark shade for light mode and white shade for dark mode and do the same

@THEBOSS0369
Copy link
Author

THEBOSS0369 commented Oct 17, 2024

@sudhanshutech @vishalvivekm ! I have removed the code from the required searchbox's respective files and add it to the global styles so that in future we don't have to copy paste the whole code and changed the icon's color from black to white as you told me.
Note: I have also removed the code from the News Section as well.

I hope this PR is in its ending phase now.

Here are the Results!

Screenshot 2024-10-17 121657
Screenshot 2024-10-17 121755
Screenshot 2024-10-17 121831
Screenshot 2024-10-17 121912
Screenshot 2024-10-17 122034

@l5io
Copy link
Contributor

l5io commented Oct 17, 2024

🚀 Preview for commit 68e48e9 at: https://6710b9a97d9bdaacec91dbd0--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Dark-mode friendly support for search input field
7 participants