Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Columns helper for sqlite #230

Merged

Conversation

nickspoons
Copy link
Contributor

Most of the other adapter types have a "Columns" helper, but not sqlite, so this PR adds it.

Copy link
Owner

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the tests? Thanks!

@nickspoons
Copy link
Contributor Author

Yes I'll have a look, but it looks like the same tests were failing before this PR so I suspect it's unrelated

Copy link
Owner

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, nvm then. Thanks!

@kristijanhusak kristijanhusak merged commit e1585fd into kristijanhusak:master May 1, 2024
4 of 12 checks passed
@nickspoons nickspoons deleted the add_sqlite_columns_helper branch May 1, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants