Fix mssql instance names #1000
Merged
Fix mssql instance names #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes code that automatically translates
localhostto127.0.0.1or similar, before using the MSSQL driver.This code was previously useful but I can't find any evidence that it currently is, and it is preventing MSSQL instance names from working. That code may have been useful for older MSSQL drivers... or if localhost is using only IPv4 or IPv6... but it needs to be removed since it's causing issues, and supporting exactly what the MSSQL driver supports is a better non-surprising behaviour.
Related links:
#999
Checklist: