Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Endless Zim Search Suggestions #1224

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Implement Endless Zim Search Suggestions #1224

wants to merge 17 commits into from

Commits on Oct 14, 2024

  1. Introduce suggestionlistmodel.{h, cpp} 

    Allow future customizing of suggestions.
    @ShaopengLin
    ShaopengLin committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    93202b8 View commit details
    Browse the repository at this point in the history

  2. Move SearchBarLineEdit urlList to SuggestionListModel 

    More cohesive design to utilize new model's index data.
    @ShaopengLin
    ShaopengLin committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    568a8b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Remove redundant openCompletion(str, int) 

    Data required can be retrieved from model.
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    64deeb7 View commit details
    Browse the repository at this point in the history

  2. Introduce SearchBarLineEdit::getDefaultSuggestionIndex 

    Remove unecessary checks and prevent misuse if openCompletion.
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c08d8df View commit details
    Browse the repository at this point in the history

  3. Enter Library::getBookIcon() 

    Refactor to simplify book icon retrieval
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5b2e534 View commit details
    Browse the repository at this point in the history

  4. Add Suggestion Icon Decoration Role

    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cda9159 View commit details
    Browse the repository at this point in the history

  5. Refactor SuggestionListWorker 

    Add offset and fetch size, prepare for endless.
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    de7522c View commit details
    Browse the repository at this point in the history

  6. Refactor Launching SuggestionListWorker 

    Automatically determine start and allow custom callback. Prepare for endless
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0fdf8a7 View commit details
    Browse the repository at this point in the history

  7. Introduce Endless Suggestions 

    Trigger on scroll.
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0afc596 View commit details
    Browse the repository at this point in the history

  8. Endless Suggestion Key Scrolling compatible 

    Down/Page_Down Key press correctly fetches.
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    aac3c9c View commit details
    Browse the repository at this point in the history

  9. Correctly handle Endless w/Fulltext 

    Fetch offset and model removal requires this.
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d69c5c4 View commit details
    Browse the repository at this point in the history

  10. Fetch Only When More Suggesion Exist

    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cc26023 View commit details
    Browse the repository at this point in the history

  11. Make First Row Visible on Suggestion Popup 

    Before, view scroll to row based on prefix match
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e307add View commit details
    Browse the repository at this point in the history

  12. Introduce Kiwix Search Header

    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    954d7d6 View commit details
    Browse the repository at this point in the history

  13. Replace m_completer.popup() with m_suggestionView

    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b0437c9 View commit details
    Browse the repository at this point in the history

  14. BugFix openCompletion Connected Multiple Times 

    Focus event can happen more than once.
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    833d61b View commit details
    Browse the repository at this point in the history

  15. Fix Suggestion Flickering when Typing 

    setCompleter call setCompletionPrefix on typing which flicker
    @ShaopengLin
    ShaopengLin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    07aa791 View commit details
    Browse the repository at this point in the history