Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Open/Save dialog on downloading files #1123

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Show Open/Save dialog on downloading files #1123

wants to merge 5 commits into from

Commits on Jul 19, 2024

  1. KiwixConfirmBox is now KiwixMessageBox 

    It started as a simple yes/no box but is now being used as an InfoBox, ConfirmBox and a customized MessageBox (in further commits) - this sounds better!
    @juuz0 @kelson42
    juuz0 authored and kelson42 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    405bbd7 View commit details
    Browse the repository at this point in the history

  2. Introduce showKiwixMessageBox() 

    Added a function to show custom choices instead of yes/no. The chosen option is returned
A closeButton is also added to the dialog.
    @juuz0 @kelson42
    juuz0 authored and kelson42 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2efd924 View commit details
    Browse the repository at this point in the history

  3. Open/Save functionality for downloaded files

    @juuz0 @kelson42
    juuz0 authored and kelson42 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9aefb8f View commit details
    Browse the repository at this point in the history

  4. Remember previous download location 

    The last downloaded file's location is remembered and the "Save File" dialog opens in the same directory.
    @juuz0 @kelson42
    juuz0 authored and kelson42 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3ce2423 View commit details
    Browse the repository at this point in the history

  5. fixup! Introduce showKiwixMessageBox()

    @juuz0 @kelson42
    juuz0 authored and kelson42 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f046af2 View commit details
    Browse the repository at this point in the history