styles: updates the home page #93
Conversation
|
@JeelRajodiya pl review. |
There was a problem hiding this comment.
As per my comments in the issue, the design of this page needs to match that of the home page: https://json-schema.org/. This design does not match that. Just glancing at it, I can tell the font doesn't even match.
We need to agree on a design before work is done.
|
ok will update once the new design is finalized. Sorry for pulling a request without asking. |
|
@pavanydg you had asked, and that's great. But there was conversation on the issue that had not been resolved. I don't want to you feel you broke some rule; I just don't want you to feel like you wasted your time. We discuss the change that needs to happen, then we implement the change. |
app/components/HomePage/HomePage.tsx
Outdated
There was a problem hiding this comment.
It's Great, can you please use CSS grid of 4 rows each, this can make the links dynamic, incase we need to add more additional chapters we won't need to modify this component.
This video can help: https://www.youtube.com/watch?v=705XCEruZFs
There was a problem hiding this comment.
Ok thanks I will do it once the design is finalized.
There was a problem hiding this comment.
hey i tried using grid, but the thing is it fills row wise. So the outcome will look like
1.Getting Started 2.PrimitiveTypes
and then from next line. So i have modified the previous code such that if we add additional chapters it works fine.
There was a problem hiding this comment.
You can resolve the row wise filling issue using the grid-auto-flow CSS property. Let me know if that does not work.
There was a problem hiding this comment.
that property is not working as desired
There was a problem hiding this comment.
it's okay. You can continue working on the rest of the design.
|
@JeelRajodiya pl review. |
|
@JeelRajodiya pl review. |
|
It's perfect! Thank you for your contribution @pavanydg |
What kind of change does this PR introduce?
enhances the home page.
Issue Number:
Screenshots/videos:
Screencast.from.10-06-2024.10.11.02.PM.webm
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?