Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed UI to show toast when progress is reset #89

Merged

Conversation

fudgemasterultra
Copy link
Contributor

@fudgemasterultra fudgemasterultra commented Oct 3, 2024

Closes #84
I changed the verbiage on isCleared to isOpen to signify the model status. I stayed in line with the current theme on the project.

Screenshot_20241003_110741
Screenshot_20241003_110800

Copy link
Member

@JeelRajodiya JeelRajodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I tried testing your code, but I couldn't. When I click on the Reset Progress button and move my cursor towards the confirmation box, it disappears! Please see the below clip. Can you please resolve it?

input

@JeelRajodiya
Copy link
Member

JeelRajodiya commented Oct 4, 2024

I checked out into the main branch and this issue with confirmation box is also there, but it is not on the main deployed version. not sure about reason. I am looking into it

@JeelRajodiya
Copy link
Member

Hello @fudgemasterultra, It seem that the problem was from my side. Apologies.

@JeelRajodiya
Copy link
Member

It works perfectly, Thank you for your contributions @fudgemasterultra

@JeelRajodiya JeelRajodiya merged commit 9a79208 into json-schema-org:main Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI to show appropriate feedback on the clearing the progress
2 participants