Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the landing Page responsive #83

Conversation

RonakSurana-2001
Copy link

Earlier the landing page(JSON Schema Tour Page) was not responsive. You can see in the video below.

Original.mp4

Now I have made the landing page responsive. The new page look video you can see below.

Updated.mp4

This issue was also raised by someone #67
Hope you like the change and any problem or query you can reply to me.

@JeelRajodiya
Copy link
Member

Hello @RonakSurana-2001, We appreciate your efforts, but as mentioned in the issue itself, We are not planning to add mobile friendly styles in the project. previously we were redirecting the mobile users to /mobile (issue #48), but since google was identifying all the pages with "page with redirect" (#47) we had to revert that commit (9e48063).

I am sorry but I have to close this PR as not planned. Please refrain from opening PRs without getting assigned to the issue. If you wish to contribute, look for the issues with Available tag and ask to get assigned, I am happy to receive your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants