Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename allocation_sample_rate to allocation_interval #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuay03
Copy link
Collaborator

@joshuay03 joshuay03 commented Sep 20, 2024

Closes #91

Renames the CLI flag from --allocation_sample_rate to --allocation-interval (hyphen for consistency with --start-paused, also pretty standard).

Renames the option kwarg from allocation_sample_rate to allocation_interval. Also renamed vars to match.

@joshuay03 joshuay03 marked this pull request as ready for review September 20, 2024 10:36
@joshuay03
Copy link
Collaborator Author

@jhawthorn Please let me know if you have any strong reservations about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flag cleanup?
1 participant