#6198 Fix missing transcoding speed info #6199
Conversation
Cloudflare Pages deployment
|
|
| @@ -200,7 +200,7 @@ function getDisplayTranscodeFps(session, player) { | |||
| const mediaSource = playbackManager.currentMediaSource(player) || {}; | |||
| const videoStream = (mediaSource.MediaStreams || []).find((s) => s.Type === 'Video') || {}; | |||
|
|
|||
| const originalFramerate = videoStream.AverageFrameRate; | |||
| const originalFramerate = videoStream.AverageFrameRate || videoStream.RealFrameRate; | |||
There was a problem hiding this comment.
Better to use videoStream.ReferenceFrameRate || videoStream.RealFrameRate?
See also jellyfin/jellyfin#12603
There was a problem hiding this comment.
Ah, I have mostly only looked at jellybin-web, not at jellyfin-server.
I assume that ReferenceFrameRate could only possibly exist with newer Jellyfin-Server releases. Otherwise, if you have a newer web but older server then nothing would change.
I guess it depends on if web releases should work with older server releases or not. If yes then maybe it is needed to do
videoStream.ReferenceFrameRate || videoStream.AverageFrameRate || videoStream.RealFrameRate
But if older server releases dont matter, then I currently see no way how ReferenceFrameRate could ever be null, in that case maybe even const originalFramerate = videoStream.ReferenceFrameRate is enough 🤔
Though videoStream.ReferenceFrameRate || videoStream.RealFrameRate is probably also a healthy middleground. Something that ensures backwards compatibility (without fixing the bug) but something that also works for the future 🤔
There was a problem hiding this comment.
We try to support one "major" version back when possible.
I noticed that the MediaInfoItem
jellyfin-web/src/components/itemMediaInfo/itemMediaInfo.js
Lines 131 to 133 in 39ec804
stream.AverageFrameRate || stream.RealFrameRate. However in the Playback Info Widget onlyvideoStream.AverageFrameRateis used. This results in the Playback Info Widget not showing how much faster the transcoding process is compared to the original frames per seconds.Changes
To also use the RealFrameRate in
getDisplayTranscodeFps, in case the AverageFrameRate is null.Issues
#6198