Make 64 bit int a 64 bit int in Swift #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a negligible change and something I'll have to think about. I will probably initially have this in a separate branch for "32 bit support" until I think about a Swiftfin Apple Watch app. Too bad the server stores these runtimes as microseconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm working on a Jellyfin client, one of the platforms I'm supporting is the Apple Watch. The Apple Watch is only 64 bit when specified and as a result when integers are above the 32 bit limit there's an error. This PR fixes that issue. However, it requires slight change of code for clients as it's changing the data type. Thank you so much, have a good night!