Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Features #1987

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Renbo2024
Copy link

@Renbo2024 Renbo2024 commented Oct 11, 2024

Changes

Added 2 new features:

  1. New setting Episode Next Up Behavior which controls the behavior when a Next Up show episode is clicked from the home screen. It may either navigate to a description page of the episode, or navigate to the season that episode is in, and select the episode.
  2. New setting OSD Remaining Time which controls what information is shown in the video player bottom OSD (when visible) on the right side. It may either show Remaining Time (current default behavior), completion Time of Day, or both.

This adds a setting with controls the type of data displayed for remaining time: remaining time, completion time of day, or both.
@Renbo2024 Renbo2024 marked this pull request as ready for review October 11, 2024 20:23
@Renbo2024 Renbo2024 requested a review from a team as a code owner October 11, 2024 20:23
@cewert
Copy link
Member

cewert commented Oct 11, 2024

New setting Episode Next Up Behavior... It may either play the episode immediately (current default behavior), navigate to a description page of the episode, or navigate to the season that episode is in, and select the episode.

IMO we should leave the "play the episode" behavior to the play button and just pick one of the two remaining options as the default behavior for everyone. That way if the user wants default audio tracks, subtitle tracks etc they hit the play button. If they want to read description, select audio track, see what time the episode ends etc. they hit the OK button.

The episode description page is just cramming an episode into the movie detail view (which itself still needs lots of work). I vote for episode list as default behavior for the OK button. Once we actually have a proper episode detail page we could revisit this and possibly change default behavior to use that instead.

edit: on second thought the episode page is better than I remember with features the episode list doesnt have. I could go either way. I still vote we pick one as default for eveything and if there's a desire make a user setting to allow either episode page or episode list

@Renbo2024
Copy link
Author

New setting Episode Next Up Behavior... It may either play the episode immediately (current default behavior), navigate to a description page of the episode, or navigate to the season that episode is in, and select the episode.

IMO we should leave the "play the episode" behavior to the play button and just pick one of the two remaining options as the default behavior for everyone. That way if the user wants default audio tracks, subtitle tracks etc they hit the play button. If they want to read description, select audio track, see what time the episode ends etc. they hit the OK button.

So then your suggestion is to differentiate the behavior of the Play and OK button? If that is the suggestion, that is what this feature does, only it allows for a customization of what to do on OK.

The episode description page is just cramming an episode into the movie detail view (which itself still needs lots of work). I vote for episode list as default behavior for the OK button. Once we actually have a proper episode detail page we could revisit this and possibly change default behavior to use that instead.

OK, so looking like your suggestion is to differentiate the OK and Play button, with OK to season episode list, and leave out the setting for default behavior entirely?

edit: on second thought the episode page is better than I remember with features the episode list doesnt have. I could go either way. I still vote we pick one as default for eveything and if there's a desire make a user setting to allow either episode page or episode list

OK, so just remove the "Play" option in the settings?

Side note: Be aware this is my VERY FIRST ever attempt at working in Brightscript. I tested as best I can, and do not see any exceptions, but if anyone has comments on how I might improve code, let me know.

@Renbo2024
Copy link
Author

Just pinging again.

If I remove the "Play" option from the setting, does this seem like an acceptable modification for approval?

@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Oct 17, 2024
@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Oct 18, 2024
@Renbo2024
Copy link
Author

I have removed "Play" from the OK button options for home screen next up show episodes. I have also resolved conflict. Please let me know if there's anything else needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants