Prevent type mismatch crash #1938
Conversation
| @@ -2099,7 +2099,7 @@ namespace api | |||
|
|
|||
| ' Gets an HLS subtitle playlist. | |||
| function GetHLSSubtitlePlaylistURL(id as string, streamindex as integer, mediasourceid as string, params = {} as object) | |||
There was a problem hiding this comment.
I'm not overly familiar with the purpose of this file, but these three functions that I'm fixing are not called anywhere in the roku codebase. Should they be deleted instead of fixed?
There was a problem hiding this comment.
I think the original sdk file had all the API calls and it was eventually trimmed down to only those we use. I'm fine with removing them.
There was a problem hiding this comment.
The original purpose of the file was to have a matching function for every API call that Jellyfin uses (https://api.jellyfin.org/). It was originally created as a roku module then later converted after we switched to brighterscript.
I don't believe we ever trimmed down the functions which is why we have errors for functions we don't use. I'm open to removing any or all of the functions we don't use
cewert
added
the
code-cleanup
Changes
Prevent type mismatches in
sdk.bswhere we were passingintegerarguments intostring-only param spots for the Substitute function. (discovered by testing out the BrighterScript v1 alpha release)Proven that this is an issue:
Issues