Add subtitile position offset option for media3 renderer #3969
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2024 20:00
nielsvanvelzen
requested changes
Sep 10, 2024
There was a problem hiding this comment.
While this does work, I'm not sure about the values. Using -10 or 100 will not display the subtitles at all so those don't feel like safe limits. The seekbar doesn't go over 52 for some reason so I had to use my mouse in the emulator (which obviously doesn't work on a real device). Also, there is no unit specified. So I can place my subtitles at "-5", -5 what? pixels? meters? dollars?
|
Hey @pbasov, are you still interested in finishing this pull request? it's currently waiting for you to address my comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back subtitle position control after client lost it when sub custom renderer has been removed in #3825
Changes
setBottomPaddingFraction.PlaybackPreferencesScreen.