Support cygwin style file path for VBoxManage arguments #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cygwin world, file path style is like UNIX style. ("c:\foo\bar" -> "/cygdrive/c/foo/bar")
But normal windows executable cannot recognize this style, so before execute VBoxManage, convert from cygwin style path to windows style are needed.
- check RbConfig::CONFIG['host_os'] for cygwin world or not
- if in cygwin world, before execute VBoxManager, convert file path by cygpath tool
|
I needed to uninstall Cygwin-based Ruby and install the “native” Windows port from rubyinstaller.org, because of the problem with Cygwin paths versus VBoxManage. This change would make Veewee more versatile in that regard. |
|
hey, is this PR still valid? if it is could you rebase it on current master so it could be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cygwin world, file path style is like UNIX style. ("c:\foo\bar" -> "/cygdrive/c/foo/bar")
But normal windows executable cannot recognize this style, so before execute VBoxManage, convert from cygwin style path to windows style are needed.