Fix for #598 #619
Open
Fix for #598 #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip port-forwarding for VMs that do not have a NAT NIC.
|
I ran into the same issue as the one mentioned in the above issue #598, is this not ready to be merged, or any other reason this hasn't been accepted yet? |
|
I also ran into this issue. Look forward to see it merged. |
|
The veewee I installed from gem (0.3.12) switches on skip_nat_mapping. If I edit my OSX definition to 'skip_nat_mapping => true', I can get past this. |
|
hey, is this PR still valid? if it is could you rebase it on current master so it could be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip port-forwarding for VMs that do not have a NAT NIC.