refactor: separate catalog schema API #25468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiltontj
force-pushed
the
hiltontj/catalog-interfaces
branch
4 times, most recently
from
eabaaa6
to
f861337
Compare
hiltontj
force-pushed
the
hiltontj/catalog-interfaces
branch
from
f861337
to
6368be3
Compare
pauldix
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out methods of the Catalog API that are used on the query side into a new trait
DatabaseSchemaProvider. The new trait includes methods from the Catalog that get the underlyingDatabaseSchemaor interact with names/IDs.This will allow for a separate implementation of the Catalog for pro that only needs to hold a replicated/combined view in-memory of one or more catalogs without the need to do persistence that a write buffer's catalog needs to do.
While in there I also switched the
QueryExecutorImpl::newmethod to take an args struct to avoid the clippy lint.