Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump github action versions #685

Merged
merged 1 commit into from
Oct 16, 2024
Merged

chore: Bump github action versions #685

merged 1 commit into from
Oct 16, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 16, 2024

This is an attempt to fix the recent workflow errors complaining about python v3.7 not being available for Ubuntu 24.04. While being at it, this PR bumps all actions to their latest available version.

@srebhan srebhan marked this pull request as draft October 16, 2024 14:10
@srebhan srebhan force-pushed the bump_actions branch 2 times, most recently from 60a7db8 to d018996 Compare October 16, 2024 14:32
@srebhan srebhan marked this pull request as ready for review October 16, 2024 14:32
Copy link

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

with:
python-version: 3.7
python-version: '3.x'
Copy link

@jdstrand jdstrand Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting. For posterity, @srebhan and I discussed this elsewhere and with the current ubuntu-latest (24.04), the earliest version available to workflows is 3.8, which is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and python is used for ct lint as stated in the helm/chart-testing-action readme. So I think there is very little that could go wrong there. (Famous last words... ;-))

@srebhan srebhan merged commit b80cf2a into master Oct 16, 2024
2 checks passed
@srebhan srebhan deleted the bump_actions branch October 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants