Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect type coercion on float64 and int64 lists in aggregators #665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djm4686
Copy link

@djm4686 djm4686 commented Aug 20, 2024

Aggregators with a list containing floats such as:

  aggregators:
    - quantile:
        quantiles: [0.25, 0.5, 0.75, 0.9, 0.95, 0.99]

Are not parsed properly by helm templates. The above results in a configmap like so:

    [[aggregators.quantile]]
      quantiles = [
        0,
        0,
        0,
        0,
        0,
        0
      ]

This is due to the _helpers.tpl template improperly coercing types for lists containing ints or floats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant