Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ios error reason user canceled #2616

Merged
merged 1 commit into from
Dec 8, 2023
Merged

feat: add ios error reason user canceled #2616

merged 1 commit into from
Dec 8, 2023

Conversation

cervebar
Copy link
Contributor

@cervebar cervebar commented Nov 18, 2023 •
edited
Loading

  • adding user canceled error code, so we can distinguish in app what error is intention and what is real error

@cervebar cervebar marked this pull request as ready for review November 18, 2023 19:42
hyochan
hyochan approved these changes Dec 8, 2023
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan added 📱 iOS Related to iOS 🎯 feature New feature labels Dec 8, 2023
@hyochan hyochan merged commit 382ccf9 into hyochan:main Dec 8, 2023
1 check passed
arthurgeron pushed a commit to arthurgeron/react-native-iap that referenced this pull request Jan 7, 2024
@cervebar
feat: add ios error reason user canceled (hyochan#2616)
bd28785 
- adding user canceled error code, so we can distinguish in app what
error is intention and what is real error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🎯 feature New feature 📱 iOS Related to iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cervebar @hyochan