Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flavors in android #6

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Sep 3, 2024

No description provided.

@hyochan hyochan added 🧹 chore 🤖 android Related to android labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Risk Level 2 - /home/runner/work/expo-iap/expo-iap/plugin/tests/fixtures/buildGradleFiles.ts

The removal of the dimension line in the googlePlay product flavor could potentially cause issues if the dimension is required elsewhere in the build configuration. Ensure that this change is intentional and that the dimension is not needed.


Risk Level 3 - /home/runner/work/expo-iap/expo-iap/plugin/src/withIAP.ts

  1. The addToBuildGradle function has been removed. Ensure that this functionality is not required elsewhere in the codebase.
  2. The WarningAggregator.addWarningAndroid call has been removed. This could lead to a lack of visibility into issues during the configuration process. Consider keeping this warning mechanism to aid in debugging.
  3. The withIAP function now catches errors but does not log them. Consider logging the error to help with debugging.

Example:

try {
  config = withIAPAndroid(config);
} catch (error) {
  console.error(`There was a problem configuring expo-iap in your native Android project: ${error}`);
}

🔍🛠️⚠️


Powered by Code Review GPT

- Removed the modifyAppBuildGradle function as it was not being used.
- Eliminated all references to modifyAppBuildGradle in the codebase.
- Updated withIAPAndroid to only handle withProjectBuildGradle.
- The withProjectBuildGradle function now ensures the supportLibVersion setting is properly added if it is missing.
- Streamlined the code by removing unnecessary functionality.
@hyochan hyochan merged commit 1a365d1 into main Sep 3, 2024
1 check passed
@hyochan hyochan deleted the chore/remove-flavors-android branch September 3, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 🧹 chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant