[LoRA] make set_adapters() robust on silent failures.
#9618
+68
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
commented
Oct 9, 2024
Comment on lines
+196
to
+198
| @unittest.skip("Not supported in CogVideoX.") | ||
| def test_simple_inference_with_text_denoiser_multi_adapter_block_lora(self): | ||
| pass |
There was a problem hiding this comment.
Now that we're catching the error appropriately within the code, we should skip this test for unsupported models.
sayakpaul
commented
Oct 9, 2024
| @@ -162,6 +162,10 @@ def test_simple_inference_with_text_denoiser_block_scale_for_all_dict_options(se | |||
| def test_modify_padding_mode(self): | |||
| pass | |||
|
|
|||
| @unittest.skip("Not supported in Flux.") | |||
There was a problem hiding this comment.
sayakpaul
commented
Oct 9, 2024
| @@ -111,6 +112,10 @@ def tearDown(self): | |||
| gc.collect() | |||
| torch.cuda.empty_cache() | |||
|
|
|||
| @is_flaky | |||
There was a problem hiding this comment.
There's absolutely no reason for it to be flaky but I think okay for now.
sayakpaul
commented
Oct 9, 2024
| @@ -108,3 +114,7 @@ def test_simple_inference_with_text_denoiser_block_scale_for_all_dict_options(se | |||
| @unittest.skip("Not supported in SD3.") | |||
| def test_modify_padding_mode(self): | |||
| pass | |||
|
|
|||
| @is_flaky | |||
There was a problem hiding this comment.
Same as #9618 (comment).
BenjaminBossan
approved these changes
Oct 9, 2024
|
@BenjaminBossan thanks!
Good catch. Resolved in 2714043. |
|
@DN6 could you give this a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, if we do
where
pipeis an instance of theFluxPipelineit doesn't error out whereas it should because Flux doesn't have any UNet and itstext_encoder_2component isn't LoRA-loadable:diffusers/src/diffusers/loaders/lora_pipeline.py
Line 1650 in 31058cd
Instead, we silently ignore things. This PR fixes this behavior.
Thanks to @asomoza for the idea in #9542 (comment)!