Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 2 styles of text filtering #1851

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

entrotech
Copy link
Member

@entrotech entrotech commented Sep 19, 2024

Fixes #1850

What changes did you make?

  • Implement 2 different styles of column heading filtering for text-based columns

Why did you make the changes (we will use this info to test)?

  • So designers, PMs and stakeholders can experience two different approaches and make decisions about what to implement

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

N/A

Visuals after changes are applied

Prototype Style (Stripped down Google Sheets style control)
image

Standard Multi-Select Drop-Down Style:
image

@entrotech entrotech merged commit efef6b4 into develop Sep 19, 2024
2 checks passed
@entrotech
Copy link
Member Author

Adjustments requested on 9/19/24:

  1. Center the Reset and Apply buttons on the Text Search popup
  2. Move the search icon to the right of the input box on the Address style TextPopup
  3. Remove the placeholder text from the input box on the Address style TextPopup.
  4. Change the placeholder text on the Name style TextPopup to "Filter".
  5. On Name style TextPopup, make it so the list box does not close when you select each item from the list.
  6. Try to contain the drop-down list in the Name style TextPopup to stay within the popup boundaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiment: Try two different implementations of filtering text columns on the My Projects Page
1 participant