Feature UI improvements #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request grishka#139 from dievskiy/master
fedorovdima
approved these changes
Feb 24, 2021
|
Good work, but bar is not visible for rooms without names |
You are totally right. I have fixed that. |
|
All good now |
|
👍👍 |
grishka
reviewed
Feb 24, 2021
| @@ -195,7 +277,6 @@ public ChannelViewHolder(){ | |||
|
|
|||
| itemView.setOutlineProvider(roundedCornersOutline); | |||
| itemView.setClipToOutline(true); | |||
| itemView.setElevation(V.dp(2)); | |||
|
Maybe it would look better if you move it to the bottom? And change to color to white. And add a shadow. This what it looks like now: |
grishka
reviewed
Feb 24, 2021
Comment on lines
90
to
92
| LayoutInflater inflater = LayoutInflater.from(getActivity()); | ||
| View returnBar = inflater.inflate(R.layout.return_row_bar, null); | ||
| ViewGroup.LayoutParams layoutParams = new ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT); |
grishka
reviewed
Feb 24, 2021
| </shape> | ||
| </item> | ||
|
|
||
| </transition> |
There was a problem hiding this comment.
This commit wasn't related to the "return bar" feature. The idea was to make channel item more rounded towards official UI.
|
|
|
Can you make an apk of this (or maybe with other pull requests). |
|
@Sapoose most of them are here: https://github.com/mkljczk/Houseclub/releases/tag/1.0.8-mkljczk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bar below toolbar that allows returning to the active channel.
Small UI improvements.