Invite and search users feature #144

bit-world · 2021-02-23T20:18:03Z

that's better?

grishka · 2021-02-23T20:41:16Z

Still has Russian strings from another pull request
The contact search part makes no sense. You query the content provider every time the search query changes, you then filter the rows using a regular expression for no good reason, and you compile it twice for each row processed. If that's not bad enough, you do it all on the UI thread. You could load the full contact list once and then filter it without any additional content provider queries.
The buttons in the confirmation dialog use hardcoded strings

lanalabinsta · 2021-02-23T20:41:43Z

Could u explain how to use it as a code? How I could add it to app?

bit-world · 2021-02-23T20:55:22Z

and you compile it twice for each row processed

Why twice?

I'll fix the rest

fedorovdima · 2021-02-23T21:16:14Z

Houseclub/src/main/java/me/grishka/houseclub/fragments/InviteListFragment.java

+                                ContactsContract.CommonDataKinds.Phone.NUMBER));
+
+                        if (query.equals("") || (
+                                Pattern.compile(Pattern.quote(query), Pattern.CASE_INSENSITIVE).matcher(name).find() ||


complied 1st time

Could it be like this?

--- a/Houseclub/src/main/java/me/grishka/houseclub/fragments/InviteListFragment.java +++ b/Houseclub/src/main/java/me/grishka/houseclub/fragments/InviteListFragment.java @@ -116,9 +116,10 @@ public class InviteListFragment extends SearchListFragment { String phoneNo = pCur.getString(pCur.getColumnIndex( ContactsContract.CommonDataKinds.Phone.NUMBER)); + Pattern pattern = Pattern.compile(Pattern.quote(query), Pattern.CASE_INSENSITIVE); if (query.equals("") || ( - Pattern.compile(Pattern.quote(query), Pattern.CASE_INSENSITIVE).matcher(name).find() || - Pattern.compile(Pattern.quote(query), Pattern.CASE_INSENSITIVE).matcher(phoneNo).find())) { + pattern.matcher(name).find() || + pattern.matcher(phoneNo).find())) { FullUser u = new FullUser(); u.name = name;

thanx, now understood

fedorovdima · 2021-02-23T21:16:24Z

Houseclub/src/main/java/me/grishka/houseclub/fragments/InviteListFragment.java

+
+                        if (query.equals("") || (
+                                Pattern.compile(Pattern.quote(query), Pattern.CASE_INSENSITIVE).matcher(name).find() ||
+                                        Pattern.compile(Pattern.quote(query), Pattern.CASE_INSENSITIVE).matcher(phoneNo).find())) {


compiled 2nd time

Is there anyone who can send me invitation

2

3

alexeysi · 2021-02-23T22:01:37Z

Looks good and better than #105 👋 🤚🤙🤙🤙

impozzible · 2021-02-23T22:11:09Z

This model is not available in your pull request

import me.grishka.houseclub.api.model.Contact;

bit-world · 2021-02-23T22:18:33Z

This model is not available in your pull request

import me.grishka.houseclub.api.model.Contact;

can you check, is it ok now?

impozzible · 2021-02-23T22:20:59Z

This model is not available in your pull request
import me.grishka.houseclub.api.model.Contact;

can you check, is it ok now?

`

    public class Contact {
public String name, phone_number;
public Contact(){
}

public Contact(String name, String phone_number){
	this.name=name;
	this.phone_number=phone_number;
}

     }

`

phone_number should be phone, because

if (query.equals("") || ( pattern.matcher(contact.name + contact.phone).find())) { FullUser user = new FullUser(); user.name = contact.name; user.bio = contact.phone; users.add(user); i++; if(i > limit) break; }

bit-world · 2021-02-23T22:24:33Z

phone_number should be phone, because

the correct option "phone_number", such response from API, initially did not know, I had to fix it

ClubhouseAPI: Raw response: {"num_invites":0,"suggested_invites":[{"phone_number":"+000000","in_app":true,"is_invited":false,"num_friends":73}

bit-world · 2021-02-23T22:26:18Z

me.grishka.houseclub.api.model.FullUser;

this is not my class, it is from origin

impozzible · 2021-02-23T22:29:44Z

Also, you need to push HomeFragment.java

bit-world · 2021-02-23T23:21:18Z

And please add a Navigation to your InviteListFragment and SearchListFragment into HomeFragment to have an access to your new features.

Done

impozzible · 2021-02-23T23:38:14Z

On my end page is just rolling

impozzible · 2021-02-24T00:11:18Z

Oh never mind, that was because i had thousands of contacts on my device

alexeysi · 2021-02-24T00:18:40Z

Oh never mind, that was because i had thousands of contacts on my device
Me too, but it works fine....

RikuAlice01 · 2021-02-24T00:28:04Z

Hey you can use API "get_suggested_invites" put phone number for check in_app and is_invited status
it will look good for filter fitting row

alexeysi · 2021-02-24T04:07:54Z

UserListFragment.java sometimes getting zero length data array and out of bounds exception in getImageURL()

Please use following implementation...

@OverRide
public String getImageURL(int position, int image){
if (data.size()>0) return data.get(position).photoUrl;
return null;
}

grishka · 2021-02-24T05:55:49Z

Houseclub/src/main/java/me/grishka/houseclub/fragments/HomeFragment.java

 		}
-		return true;
+		return false;


I'm changed this return to false independently too. Dunno why, but got some exceptions in navigation when more than 2 items in a menu...

@bit-world: with true here I had the same problem as @josefjebavy described, couldnt navigate twice to the same page.

grishka · 2021-02-24T05:58:40Z

Houseclub/src/main/res/values/strings.xml

+	<string name="button_positive">Ok</string>
+	<string name="button_negative">Cancel</string>


These strings already exist...

grishka · 2021-02-24T05:59:01Z

Houseclub/src/main/java/me/grishka/houseclub/fragments/InviteListFragment.java

+                                    Toast.makeText(getContext(), getString(R.string.invite_err, ""), Toast.LENGTH_SHORT).show();
+                                    error.showToast(getContext());


This is indented with spaces for some reason

grishka · 2021-02-24T05:59:19Z

Houseclub/src/main/java/me/grishka/houseclub/fragments/InviteListFragment.java

+            super(getActivity(), R.layout.user_list_row);
+
+            name=findViewById(R.id.name);
+            bio=findViewById(R.id.bio);
+            followBtn=findViewById(R.id.follow_btn);
+            photo=findViewById(R.id.photo);


And this too

josefjebavy · 2021-02-25T18:39:48Z

Hi i tested this feature:

invitation - it look that it is work.
notificiation page - first time it is display, but than this page always fall

alexeysi · 2021-02-26T18:06:42Z

Hi i tested this feature:

invitation - it look that it is work.
+1. Confirming, I also used my invite and it passed to another android user successfully.

notificiation page - first time it is display, but than this page always fall
Try to change HomeFragment.java line143: to return false; instead of true;

remove other characters from the phone number

Invite and search users feature

acab89d

fedorovdima reviewed Feb 23, 2021

View reviewed changes

bit-world added 5 commits February 24, 2021 00:39

Update InviteListFragment.java

7dbc357

Delete strings.xml

744d351

Update strings.xml

aaf582a

Update InviteListFragment.java

3b47608

2

Update InviteListFragment.java

ce5b2c7

3

bit-world added 3 commits February 24, 2021 01:12

Update InviteListFragment.java

5155eac

Merge branch 'master' of https://github.com/bit-world/Houseclub

121bac6

Add model/Contact.java

b4d8c76

Get_suggested_invites implementation

5fe781d

muhammedabohalima approved these changes Feb 24, 2021

View reviewed changes

fedorovdima approved these changes Feb 24, 2021

View reviewed changes

grishka reviewed Feb 24, 2021

View reviewed changes

bit-world added 4 commits February 24, 2021 14:23

Update strings.xml

97edde1

Update InviteListFragment.java

67927e6

Update HomeFragment.java

b1ee174

Update InviteListFragment.java

53ba0e8

bit-world mentioned this pull request Feb 24, 2021

Implement invitation by phone number #154

Merged

to tabs

7f290dd

bit-world requested a review from grishka February 25, 2021 14:26

bit-world added 6 commits February 27, 2021 21:09

Merge branch 'master' into master

58be430

Update InviteListFragment.java

47862cd

remove other characters from the phone number

Merge branch 'master' of https://github.com/bit-world/Houseclub

2527bfe

Create SearchUsers.java

17ec2b2

Delete SearchPeople.java

2dd85e3

Update SearchListFragment.java

12c6669

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Invite and search users feature #144

Invite and search users feature #144

bit-world commented Feb 23, 2021

grishka commented Feb 23, 2021

lanalabinsta commented Feb 23, 2021

bit-world commented Feb 23, 2021

fedorovdima Feb 23, 2021

fedorovdima Feb 23, 2021 •

edited

Loading

bit-world Feb 23, 2021 •

edited

Loading

fedorovdima Feb 23, 2021

gallanmw Mar 12, 2021

alexeysi commented Feb 23, 2021

impozzible commented Feb 23, 2021

bit-world commented Feb 23, 2021

impozzible commented Feb 23, 2021 •

edited

Loading

bit-world commented Feb 23, 2021

bit-world commented Feb 23, 2021

impozzible commented Feb 23, 2021

bit-world commented Feb 23, 2021

impozzible commented Feb 23, 2021

impozzible commented Feb 24, 2021

alexeysi commented Feb 24, 2021

RikuAlice01 commented Feb 24, 2021

alexeysi commented Feb 24, 2021

grishka Feb 24, 2021

alexeysi Feb 24, 2021

bit-world Feb 24, 2021

alexeysi Feb 26, 2021

grishka Feb 24, 2021

bit-world Feb 24, 2021

grishka Feb 24, 2021

bit-world Feb 24, 2021

grishka Feb 24, 2021

bit-world Feb 24, 2021

josefjebavy commented Feb 25, 2021

alexeysi commented Feb 26, 2021

		<string name="button_positive">Ok</string>
		<string name="button_negative">Cancel</string>

		Toast.makeText(getContext(), getString(R.string.invite_err, ""), Toast.LENGTH_SHORT).show();
		error.showToast(getContext());

Invite and search users feature #144

Are you sure you want to change the base?

Invite and search users feature #144

Conversation

bit-world commented Feb 23, 2021

grishka commented Feb 23, 2021

lanalabinsta commented Feb 23, 2021

bit-world commented Feb 23, 2021

Choose a reason for hiding this comment

fedorovdima Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

bit-world Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexeysi commented Feb 23, 2021

impozzible commented Feb 23, 2021

bit-world commented Feb 23, 2021

impozzible commented Feb 23, 2021 • edited Loading

bit-world commented Feb 23, 2021

bit-world commented Feb 23, 2021

impozzible commented Feb 23, 2021

bit-world commented Feb 23, 2021

impozzible commented Feb 23, 2021

impozzible commented Feb 24, 2021

alexeysi commented Feb 24, 2021

RikuAlice01 commented Feb 24, 2021

alexeysi commented Feb 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josefjebavy commented Feb 25, 2021

alexeysi commented Feb 26, 2021

fedorovdima Feb 23, 2021 •

edited

Loading

bit-world Feb 23, 2021 •

edited

Loading

impozzible commented Feb 23, 2021 •

edited

Loading