Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the regex used to trigger the Go github action on tags #192

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Aug 1, 2023

The previous regex wasn't accepted by the GitHub actions runner (see #180 (comment)).

The following change should allow the action to run again, at the cost of a less constraining verification made on the tags themselves.

My goal here is to get a CI back up and running quickly, improvements to the regex can be made later if/when needed.

@K-Phoen
Copy link
Member Author

K-Phoen commented Aug 1, 2023

Also: to avoid the noise due to a failing "goreleaser" action in PRs, I split the release and CI actions.

@sdboyer
Copy link
Contributor

sdboyer commented Aug 1, 2023

thank you!

@sdboyer sdboyer merged commit f67a27d into main Aug 1, 2023
1 check passed
@K-Phoen K-Phoen deleted the github-action-tag-regex branch August 1, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants