Expose Go post-processing utilities #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
reviewed
Aug 1, 2023
encoding/gocode/gen.go
Outdated
| Path: fmt.Sprintf("%s_type_gen.go", sch.Lineage().Name()), | ||
| Appliers: applyFuncs, | ||
| In: []byte(gostr), | ||
| IgnoreDiscoveredImports: !cfg.IgnoreDiscoveredImports, |
There was a problem hiding this comment.
Doesn't it look weird that IgnoreDiscoveredImports: !IgnoreDiscoveredImports? 🤔
Indeed, now I think it should be IgnoreDiscoveredImports: cfg.IgnoreDiscoveredImports, because the negation (!) has been added later, when that value is read.
Also, based on the underlying behavior, I'm not sure if the name is clear enough. I guess nothing that cannot be clarified with some extra explanation in form of docs, if needed.
EDIT: Clearly stated here, so 👌🏻
There was a problem hiding this comment.
That's a copy-pasta mistake, good catch!
K-Phoen
force-pushed
the
expose-go-postprocess
branch
from
c9ec821
to
87aa9b8
Compare
K-Phoen
force-pushed
the
expose-go-postprocess
branch
from
87aa9b8
to
f0dba70
Compare
|
Fixed, documented and added a small test case for it :) |
sdboyer
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the Go post-processing function, to be used by kindsys and other Go jennies.