Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase block-ranges-period for OOO native histogram integration test #9592

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Increase block-ranges-period for OOO native histogram integration test #9592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c838b
Increase block-ranges-period for OOO native histogram integration test
fionaliao Oct 11, 2024
aeb921c
Explicitly disable OOO NH in test
fionaliao Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions integration/ooo_ingestion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,15 @@ func TestOOOHistogramIngestionDisabled(t *testing.T) {
BlocksStorageFlags(),
BlocksStorageS3Flags(),
map[string]string{
"-ingester.out-of-order-time-window": "10m",
"-ingester.native-histograms-ingestion-enabled": "true",
"-ingester.out-of-order-time-window": "10m",
"-ingester.native-histograms-ingestion-enabled": "true",
"-ingester.ooo-native-histograms-ingestion-enabled": "false",
// Default block-ranges-period for integration tests is 1m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's add "-ingester.ooo-native-histograms-ingestion-enabled": "false" while we're at it. Just in case we change the default/remove the flag, make the test fail more explicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in aeb921c

// When OOO NH is disabled, all NH samples must be greater than or equal to minValidTime, otherwise an out
// of bounds error is returned. minValidTime which max sample time - (block-ranges-period[0]/2). Increase
// tsdb.block-ranges-period to 2h so when we ingest 1m OOO data, the out of bounds check passes and we hit
// the specific OOO NH disabled error instead.
"-blocks-storage.tsdb.block-ranges-period": "2h",
},
)

Expand Down