Optimize TileSetAtlasSource::_get_property_list
#98317
Open
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Oct 19, 2024
scene/resources/2d/tile_set.cpp
Outdated
| tile_property_list.push_back(alternative_property_info); | ||
| } | ||
| } | ||
|
|
||
| // Add all alternative. | ||
| const String property_info_prefix = vformat("%d:%d", E_tile.key.x, E_tile.key.y) + '/'; |
There was a problem hiding this comment.
Suggested change
| const String property_info_prefix = vformat("%d:%d", E_tile.key.x, E_tile.key.y) + '/'; | |
| const String property_info_prefix = vformat("%d/%d/", E_tile.key.x, E_tile.key.y); |
- Copy-paste error.
- Plus
charis unnecessary since we're already doingvformat().
There was a problem hiding this comment.
- Copy-paste error.
I think it should be %d:%d/%s with the original code, have I missed something with vformat?
There was a problem hiding this comment.
Ah yes, I looked at the wrong vformat() call.
There was a problem hiding this comment.
I mean, it's not a copy-paste error, using : is correct.
There was a problem hiding this comment.
I know, just pull to local and squash these commits, will fix it.
Co-authored-by: Haoyu Qiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98213.
TileSetAtlasSource::_get_property_listused to callvformata lot with exact same args. Replace pure string formats with string concat and move others to outer loop.use a slightly modified MRP to make the difference more clear.
testgame.zip
Test Result:
Master:
master.mp4
This PR:
pr.mp4