Add C# documentation for connecting to GDScript signals with parameters #10098
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
reviewed
Oct 17, 2024
TheSecondReal0
force-pushed
the
csharp-signal-parameters
branch
from
6d93938
to
a4c0b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of converting parts of my game to C#, and had trouble figuring out how to connect to GDScript signals that had parameters. I've updated the cross language scripting page to include the solution that worked for me.
I'm not sure of the best way to explain why you need to explicitly create a new System.Action, maybe explaining that it needs more type information to know which method to call? Any feedback on that would be much appreciated!