-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specific display preferences to be configured for the helpdesk #18001
base: main
Are you sure you want to change the base?
Allow specific display preferences to be configured for the helpdesk #18001
Conversation
d563afb
to
e168fd0
Compare
} | ||
} | ||
|
||
public function buildUpdateOrInsert($table, $params, $where, $onlyone = true): string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up not needing this new method, I've still kept it as it may be useful to someone else one day.
75f67fd
to
185df8d
Compare
@cedric-anne I'm stuck on this one. This PR add a new column to the display_preference unicity constraint. Can we discuss it on monday ? It works on MariaDB tho, I thought it was because of this: So I added |
Seems unlikely we will have more than helpdesk or central interfaces. At least for now, this could be a |
Maybe interface can be an tinyint with just constants in code GLPI side? |
c3c0bcb
to
7fff4b0
Compare
Checklist before requesting a review
Description
helpdesk
interface.supportHelpdeskDisplayPreferences()
method that returntrue
(so only ticket for now).Ticket::rawSearchOption()
).This is because:
We would need a proper service that accept a given interface and then return the available search options.
Instead, we have a direct call to
Session::getCurrentInterface()
deeply nested into the stack trace, which mean passing a specific interface value would require adding new parameters to every method in the call stack until we reachTicket::rawSearchOption()
.Ticket::rawSearchOption()
do not actually remove search options for the helpdesk, it set them asnosearch = true
.This mean they can't be used to search data but are actually valid to be used as display preferences.
Thus, it is the administrator responsibility to not add columns that may contain sensitive informations in the helpdesk view.
Screenshots