Use a custom htmlescape() function to handle unexpected null values
#17936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
reviewed
Sep 26, 2024
| "\" " . (!$_SESSION['ldap_import']['basedn'] ? "disabled" : "") . ">"; | ||
| echo "</td></tr>"; | ||
|
|
||
| echo "<tr><td class='text-end'><label for='ldap_filter'>" . __('Search filter for users') . "</label></td><td colspan='3'>"; | ||
| echo "<input type='text' class='form-control' id='ldap_filter' name='ldap_filter' value=\"" . | ||
| htmlspecialchars($_SESSION['ldap_import']['ldap_filter'], ENT_QUOTES) . "\">"; | ||
| htmlescape($_SESSION['ldap_import']['ldap_filter'], ENT_QUOTES) . "\">"; |
There was a problem hiding this comment.
Suggested change
| htmlescape($_SESSION['ldap_import']['ldap_filter'], ENT_QUOTES) . "\">"; | |
| htmlspecialchars($_SESSION['ldap_import']['ldap_filter'] ?? '', ENT_QUOTES) . "\">"; |
There was a problem hiding this comment.
CS is complaining about several issues like this one. LGTM appart of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fixes #17933.
There are many places in our code where
htmlspecialchars()may be call for a null value (or even an integer, a float, ...). Instead of using the?? ''to fix occurences that triggers a deprecation notice, I propose to use a customhtmlescape()function that ensures that non-string legitimate values are correctly handled.