Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows to 2022 and enable Android Windows Images #231

Merged
merged 17 commits into from
Nov 1, 2023

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Oct 28, 2023

Changes

  • Update windows images to 2022 from 2019. We need to do this because 2019 will go EOL in January which means Github will start failing builds using it and ultimately remove it within a few months after EOL based on how they operated with Server 2016. This means people will need to upgrade their workflows to use windows-2022 instead of windows-2019 and update any self hosted runners to support server-2022 containers (either use Windows Server 2022 or Windows 11 as their host)
  • Setup Android dependencies to allow for Android builds on Windows. This enables using Burst on Android builds which is a major performance booster.
  • Update several action workflow versions to fix dependabot warnings
  • Setup better test exclusion patterns for Windows
  • Move Unity install path to C:/UnityEditor. This fixes old versions of sdkmanager that don't handle spaces in the path. Using the UNITY_PATH environment variable will mitigate any changes like this in the future in downstream scripts.

Note builds will fail until unity-builder gets merged with the windows related changes. Here is a representative run of the test images.

Related PRs

There will likely be one more PR for bumping the major version of the docker version number in Unity Builder

Related Issues

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link

Cat Gif

…path. Increase build timeout in pr tests for windows images. Script cleanup. Better error detection and handling. Use unity-builder test branch for verification
@AndrewKahr AndrewKahr merged commit 8722a6d into main Nov 1, 2023
334 checks passed
@AndrewKahr AndrewKahr deleted the feature/windows-upgrades branch November 1, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants