newfs_msdos.8: example for specific cluster size #1045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
reviewed
Jan 12, 2024
There was a problem hiding this comment.
I would expand the commit log to include most of your comment in the PR (which I found helpful). I would perhaps leave out the last line in the comment about Windows from the log message, but the rest of the comment is useful for giving the "why" of the change.
The usual use case in 2024 for newfs_msdosfs is creating filesystems on SD cards for older hardware. In most tutorials, they call the cluster size "allocation size". Therefore, add a small note next to cluster size that it is also called allocation size, and add an example for how to do this. Co-authored-by: John Baldwin <[email protected]>
|
This is my first time trying to squash a co-authored commit, did it go okay? |
bsdjhb
approved these changes
Jan 22, 2024
|
I didn't really co-author this FWIW, I just made minor suggestions in review. The work is really your own. |
bsdjhb
pushed a commit
to bsdjhb/freebsd
that referenced
this pull request
Jan 22, 2024
The usual use case in 2024 for newfs_msdosfs is creating filesystems on SD cards for older hardware. In most tutorials, they call the cluster size "allocation size". Therefore, add a small note next to cluster size that it is also called allocation size, and add an example for how to do this. Reviewed by: jhb Pull Request: freebsd#1045
|
Merged in c8bf9f0, thanks! (Oops, missed including Mina's review in the commit) |
freebsd-git
pushed a commit
that referenced
this pull request
Apr 8, 2024
The usual use case in 2024 for newfs_msdosfs is creating filesystems on SD cards for older hardware. In most tutorials, they call the cluster size "allocation size". Therefore, add a small note next to cluster size that it is also called allocation size, and add an example for how to do this. Reviewed by: jhb Pull Request: #1045 (cherry picked from commit c8bf9f0)
freebsd-git
pushed a commit
that referenced
this pull request
Apr 8, 2024
The usual use case in 2024 for newfs_msdosfs is creating filesystems on SD cards for older hardware. In most tutorials, they call the cluster size "allocation size". Therefore, add a small note next to cluster size that it is also called allocation size, and add an example for how to do this. Reviewed by: jhb Pull Request: #1045 (cherry picked from commit c8bf9f0)
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Jul 31, 2024
The usual use case in 2024 for newfs_msdosfs is creating filesystems on SD cards for older hardware. In most tutorials, they call the cluster size "allocation size". Therefore, add a small note next to cluster size that it is also called allocation size, and add an example for how to do this. Reviewed by: jhb Pull Request: freebsd/freebsd-src#1045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual use case in 2024 for newfs_msdosfs is creating filesystems on SD cards for older hardware. In most tutorials, they call the cluster size "allocation size". Therefore, add a small note next to cluster size that it is also called allocation size, and add an example for how to do this.
Fun fact, you can't do this on Windows without downloading suspicious programs.