man: fix redirect for locales and file arguments #1019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the locale-specific path for localized pages and the appropriate parent directory for file arguments when handling redirects. Signed-off-by: Mohamed Akram <[email protected]>
mohd-akram
force-pushed
the
fix-man-so
branch
from
f265459
to
d4c3f33
Compare
|
This change looks like it should be good. How can I test, though, that it fixes the bug you are chasing? And what's the current misbehavior look like? |
|
This is how I tested: Setup: cd /tmp
mkdir -p man/man1/amd64
mkdir -p man/fr.UTF-8/man1
echo hello >man/man1/page.1
echo salut >man/fr.UTF-8/man1/page.1
echo '.so man1/page.1' >man/man1/regular.1
echo '.so man1/page.1' >man/man1/amd64/machine.1
echo '.so man1/page.1' >man/fr.UTF-8/man1/locale.1For testing the local version Tests: export MANPAGER=cat
(cd man/man1/ && man ./regular.1) #should show hello
(cd man/man1/amd64 && man ./machine.1) # should show hello
LANG=fr_FR.UTF-8 MANPATH=man man locale # should show salutIn the current version, the first two tests show nothing (because it can't find the linked man pages), and the last shows hello instead of salut (because it doesn't use the locale path). |
freebsd-git
pushed a commit
that referenced
this pull request
Feb 3, 2024
Use the locale-specific path for localized pages and the appropriate parent directory for file arguments when handling redirects. Signed-off-by: Mohamed Akram <[email protected]> Reviewed by: imp Pull Request: #1019
bsdjhb
pushed a commit
to bsdjhb/cheribsd
that referenced
this pull request
Aug 1, 2024
Use the locale-specific path for localized pages and the appropriate parent directory for file arguments when handling redirects. Signed-off-by: Mohamed Akram <[email protected]> Reviewed by: imp Pull Request: freebsd/freebsd-src#1019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the locale-specific path for localized pages and the appropriate parent directory for file arguments when handling redirects.