Add h3_cell_to_latlng #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
approved these changes
Oct 25, 2022
src/main/java/com/foursquare/presto/h3/CellToLatLngFunction.java
Outdated
Show resolved
Hide resolved
| DOUBLE.writeDouble(blockBuilder, latLng.lng); | ||
| return blockBuilder.build(); | ||
| } catch (Exception e) { | ||
| return null; |
There was a problem hiding this comment.
For my info: Is it faster to catch the exception, or faster to validate the input?
There was a problem hiding this comment.
Catching exceptions is generally very slow. uber/h3-java#107 tracks adding a no-throw API for performance.
| try (QueryRunner queryRunner = createQueryRunner()) { | ||
| assertQueryResults( | ||
| queryRunner, | ||
| "SELECT h3_cell_to_latlng(578536630256664575)", |
There was a problem hiding this comment.
Nit: Does Presto support any hexidecimal syntax? In general I think we should prefer human-readable cell indexes in tests if possible (easier to debug, etc).
There was a problem hiding this comment.
I'm not aware of a way to embed a hex literal integer in Presto SQL. (You could use a string literal and from_base)
Co-authored-by: Nick Rabinowitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.