Update patch to modify download location for lyrics #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've changed the lyrics download path from $XDG_DATA_HOME/lyrics to $XDG_DATA_HOME/$APP_ID/lyrics instead, because the former path looks way too common for comfort. I know that shouldn't matter for Flatpak, but since I'll be trying to upstream an improved version of this patch later, the old path could potentially cause issues for non-Flatpak installations of this app. Lastly, users unlucky enough to run the app with the old path will have to manually reset the app settings for this new path to be effective (Hamburger menu > Restore default settings).
|
Started test build 155512 |
|
Build 155512 successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the lyrics download path from
$XDG_DATA_HOME/lyricsto$XDG_DATA_HOME/$APP_ID/lyricsinstead, because the former path looks way too common for comfort.I know that shouldn't matter for Flatpak, but since I'll be trying to upstream an improved version of this patch later, the old path could potentially cause issues for non-Flatpak installations of this app.
Lastly, users that were unlucky enough to run the app with the old path, will have to manually reset their app settings for this new path to be effective (Hamburger menu > Restore default settings).