Fix WindowFuzzer to not generate NaN in frame bounds #11296
Closed
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Window fuzzer test is flaky due to incorrect handling of NaN in frame bounds in the Window operator (facebookincubator#11213). Presto needs to be fixed too to match Velox behavior (prestodb/presto#23822). Before then, make window fuzzer not generate NaN in frame bounds to avoid fuzzer failures. Differential Revision: D64580491
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64580491 |
✅ Deploy Preview for meta-velox canceled.
|
amitkdutta
approved these changes
Oct 18, 2024
|
This pull request has been merged in bc8c905. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Window fuzzer test is flaky due to incorrect handling of NaN in frame bounds in the Window operator (#11213).
Presto needs to be fixed too to match Velox behavior (prestodb/presto#23822).
Before then, make window fuzzer not generate NaN in frame bounds to avoid fuzzer failures.
Differential Revision: D64580491