Fix Window operator with NaN as the frame bound #11293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64510519 |
✅ Deploy Preview for meta-velox canceled.
|
kagamiori
force-pushed
the
export-D64510519
branch
from
ae5ba10
to
aaace8e
Compare
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Oct 17, 2024
) Summary: NaN could appear as the frame bound of k-range frames in window operations. When NaN appear in either of the frame bounds, the window operation should return NULL at this row. This diff fixes facebookincubator#11213. Differential Revision: D64510519
|
This pull request was exported from Phabricator. Differential Revision: D64510519 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Oct 17, 2024
) Summary: NaN could appear as the frame bound of k-range frames in window operations. When NaN appear in either of the frame bounds, the window operation should return NULL at this row. This diff fixes facebookincubator#11213. Differential Revision: D64510519
kagamiori
force-pushed
the
export-D64510519
branch
from
aaace8e
to
b249ee4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64510519 |
) Summary: NaN could appear as the frame bound of k-range frames in window operations. When NaN appear in either of the frame bounds, the window operation should return NULL at this row. This diff fixes facebookincubator#11213. Differential Revision: D64510519
kagamiori
force-pushed
the
export-D64510519
branch
from
b249ee4
to
06c9e58
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64510519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NaN could appear as the frame bound of k-range frames in window
operations. When NaN appear in either of the frame bounds, the window
operation should return NULL at this row.
This diff fixes #11213.
Differential Revision: D64510519