Track removal of ffi.h from fb-util #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be landed together with facebookincubator/hsthrift#102 which removes ffi.h from fb-util
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for fb-oss-glean canceled.
|
This was referenced Sep 11, 2022
|
@donsbot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 25, 2022
Summary: This adds support for concurrent indexing based on the existing worklist framework. There are some shenanigans related to progress reporting which mostly exist to make indexing LLVM nicer (script coming up). The other major addition is the index-llvm.sh script which automates indexing LLVM source distributions using the parallel indexer - try the example suggested in index-llvm.sh --help. I'm not sure where the script should live. On my server indexing takes about 10 min with -j16. Note that this includes #269 - we don't have stacked PRs so that one should probably be landed first. Pull Request resolved: #271 Reviewed By: simonmar Differential Revision: D39420798 Pulled By: pepeiborra fbshipit-source-id: 2dc81e20a20fb522e42557944cd4871f72099775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be landed together with facebookincubator/hsthrift#102 which removes ffi.h from fb-util