Allow building shared libraries when requested

CMake builds static libraries by default unless requested otherwise with `BUILD_SHARED_LIBS`. However, this is made impossible when you pass `STATIC` to `add_library`. Passing `STATIC` isn't really necessary, and can be a hinderance for downstream users. See, for example, facebook/mvfst#302.
facebookexperimental · Jul 3, 2024 · 9c113dc · 9c113dc
1 parent fe5fe5a
commit 9c113dc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/eden/common/testharness/CMakeLists.txt b/eden/common/testharness/CMakeLists.txt
@@ -8,7 +8,6 @@ file(GLOB testharness_sources CONFIGURE_DEPENDS *.cpp)
 
 add_library(
   edencommon_testharness
-  STATIC
   ${testharness_headers}
   ${testharness_sources}
 )

diff --git a/eden/common/utils/CMakeLists.txt b/eden/common/utils/CMakeLists.txt
@@ -26,7 +26,6 @@ endif()
 
 add_library(
   edencommon_utils
-  STATIC
     ${utils_headers}
     ${utils_sources})