Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add english document #17

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

docs: add english document #17

wants to merge 25 commits into from

Conversation

elonehoo
Copy link

@elonehoo elonehoo commented Jan 9, 2022

描述

one/docs/development/en-US/components 中增加了 accordion.md 文件,并且在 nav.json 中将禁用取消,由于是第一次编写文档,按照了中文文档的风格进行编写,如有不好的麻烦您进行指出,我会及时查阅书本进行修正。

相关问题

动机和背景

@Justineo 您好,昨天在 twitter 上看到了您的项目,发现您在评论中回答暂时没有足够的人力来进行英文文档的编写,我最近在苦练英文,想通过您的 veui 的英文文档来加强自己的英文写作能力,也希望在您这里编写的文档可以帮助到更多的同学。

这是如何测试的?

完全的按照了 veui 的 README 里面进行了安装,由于电脑的 npm 无法安装部分的包,所以使用了 yarn 来进行安装,故而增加了 .gitignore 文件。

变化类型

  • 错误修复(修复问题的非破坏性更改)
  • 新功能(增加功能的不间断更改)
  • 重大更改(会导致现有功能更改的修复或功能)

清单:

  • 我的代码遵循这个项目的代码风格。
  • 我的更改需要对文档进行更改。
  • 我已经相应地更新了文档。
  • 我添加了测试来覆盖我的更改。
  • 所有新的和现有的测试都通过了。

@vercel
Copy link

vercel bot commented Jan 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ecomfe/veui-docs/GoNNJ9h35XGEuKTb7TtnrWa34Zhq
✅ Preview: https://veui-docs-git-fork-xiaoxunyao-master-ecomfe.vercel.app

@elonehoo
Copy link
Author

加入了 锚点 的英文文档。

@elonehoo elonehoo changed the title 增加了英文的手风琴文档 docs: add english document Jan 10, 2022
@elonehoo
Copy link
Author

elonehoo commented Jan 10, 2022

发现了 offset.vue 中的描述都是中文的,所以在 demo 中也创建了一个 offset-en.vue 的示例。

@Justineo
Copy link
Member

@xiaoxunyao 非常感谢!我会抽时间 review 这个 PR。我们可以提前做一些约定:

  • 所有 demo 都直接用英文的,减少一些维护的成本。
  • API 的部分,props / slots / events / ... 不加组件的名称,build 脚本里面会自动识别出区块,对应的链接会生成为 #props-foo 这样的锚点

另外,npm 无法安装的问题是否因为版本问题?是不是可以尝试升级一下 npm 再安装一下?

@elonehoo
Copy link
Author

elonehoo commented Jan 10, 2022

@Justineo 好的,没有任何问题,我会遵守这些约定。
非常感谢您真的抽出时间来回答这个PR。
因为我的英语水平可能不是特别好,但是我会继续完成这个想法。
十分感谢大佬的回复!

@elonehoo
Copy link
Author

npm的问题我昨天找到了,因为我的学校有一些网址无法打开,所以我一般挂了VPN,然后就有一些包无法下载,我使用流量就没有任何问题了。

@elonehoo
Copy link
Author

elonehoo commented Jan 10, 2022

增加了 Autocomplete 的英文文档

@elonehoo
Copy link
Author

根据刚刚修改的地方,稍微自查了一下.

@elonehoo elonehoo closed this Jan 14, 2022
@elonehoo elonehoo reopened this Jan 14, 2022
@elonehoo
Copy link
Author

elonehoo commented Jan 15, 2022

增加了 Cascader 级联器 ,这个检查过了,我觉得我没问题 ( 理直气壮.jpg ) 。

希望检查这个的时候我不会太打脸,先立个 flag 再说。


## Demos

### Size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Size
### Size variants


### Size

Available size variants for the ui prop: `s` / `m`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Available size variants for the ui prop: `s` / `m`.
Available size variants for the [`ui`](#props-ui) prop: `s` / `m`.

one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
one/docs/en-US/components/anchor.md Outdated Show resolved Hide resolved
@Justineo
Copy link
Member

建议可以用 DeepL 做初步的机翻,效果其实还不错的,然后做些细节调整就可以了。

@elonehoo
Copy link
Author

行吧,初步用了Google然后自己改了改……主要是第二次写的时候发现好多不会……

@elonehoo
Copy link
Author

我再去改改其他的,我跟英语杠上了,我还不信能让他给我憋死!

@Justineo
Copy link
Member

慢慢来哈,这也不完全是英语的问题,我有些调整了一下是为了和之前其他部分翻译成英文的部分保持一致。中文文档也不是一个人写的,有些表达的确本身也有点问题。


[[ demo src="/demo/badge/text.vue" ]]

### Digital badge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Digital badge
### Numeric badge


### Digital badge

Badge content can be number, When the maximum value is exceeded, it can be displayed as *Maximum+*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Badge content can be number, When the maximum value is exceeded, it can be displayed as *Maximum+*.
The content can also be a number and can be can be displayed as “<var>max</var>+” when exceeding the maximum value.


[[ demo src="/demo/badge/number.vue" ]]

### Round Dots badge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里好像原文写错了,应该是飘角徽标,这里写 Corner badge 吧


### Round Dots badge

No badge content is provided, The badge will be displayed in a dot style in the upper right corner.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
No badge content is provided, The badge will be displayed in a dot style in the upper right corner.
When no badge content is provided, the badge will be displayed in the upper right corner in a dot style.

No badge content is provided, The badge will be displayed in a dot style in the upper right corner.

[[ demo src="/demo/badge/corner-dot.vue" ]]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少了个标题,Dot badge 吧

| ``input`` | Triggered when a search keyword is entered. The callback parameter is `(value: string)`, and `value` is the `value` value of the input box. |
| ``select`` | [^event-select] |
| ``afteropen`` | Fired when the drop-down menu is turned on. |
| ``afterclose`` | Fired when the drop-down menu is turned off. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| ``afterclose`` | Fired when the drop-down menu is turned off. |
| ``afterclose`` | Triggered after the dropdown panel is collapsed. |

`v-model`
:::

Triggered after the selected state changes, the callback parameter is `(value: *)`. `value` is the value of the currently selected `value` field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Triggered after the selected state changes, the callback parameter is `(value: *)`. `value` is the value of the currently selected `value` field.
Triggered after the selected state changes, the callback parameter is `(value: *)`. `value` is the value of the currently selected option value.

Triggered after the selected state changes, the callback parameter is `(value: *)`. `value` is the value of the currently selected `value` field.
^^^

### Global config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Global config
### Global configs

| ``cascader.placeholder`` | `string` | `@@cascader.placeholder` | Placeholder content when not selected. |

:::tip
A value starting with `@@` refers to the relevant field in the multilingual config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A value starting with `@@` refers to the relevant field in the multilingual config.
`@@` prefixed values denote corresponding properties in the locale settings.

A value starting with `@@` refers to the relevant field in the multilingual config.
:::

### Icon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Icon
### Icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants