Skip name prefixes for UC Schema when catalog_name contains current user
#1830
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
changed the title
catalog_name contains current user
pietern
reviewed
Oct 14, 2024
There was a problem hiding this comment.
If we roll this out as is, it will trigger recreates of dev schemas.
Can you figure out how many folks are using this today and how we can provide a ~graceful transition path? We could consider adding a setting for this behavior and default it either way. I don't particularly like the added complexity of that, though, but it's the best I can come up with on a whim.
|
|
||
| // If the catalog is already namespaced to the current user, we don't need | ||
| // to prefix the schema name since it already falls under the user's namespace. | ||
| if containsUserIdentity(s.CatalogName, b.Config.Workspace.CurrentUser) { |
There was a problem hiding this comment.
This should also check for the ShortName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addresses #1779 and #1762 (comment).
Users report schema names getting too verbose unnecessarily when the catalog already contains the user name. This PR skips prefixing for schemas if the catalog already contains the short name (eg:
shreyas_goenkaor the user's email address (eg:[email protected]).Tests
Unit tests.