Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): reduce unsafe codes in kernels #16633

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Oct 17, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. reduce unsafe codes in FilterVisitor and Take/Concat kernels
  2. introduce IterationStrategy in FilterVisitor based on https://dl.acm.org/doi/abs/10.1145/3465998.3466009

Performance did not improve, we need to re benchmark it after StringView is introduced.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 17, 2024
@sundy-li sundy-li changed the title chore(query): reduce unsafe codes in FilterVisitor chore(query): reduce unsafe codes in kernels Oct 17, 2024
@sundy-li sundy-li added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@BohuTANG BohuTANG merged commit 3b7ef8b into databendlabs:main Oct 18, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants