date-picker / date-range-picker event fixes #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a type (.calendar instead of .calendars) FIX (date-picker and date-range-picker): EVENT_START_DATE_CHANGE / EVENT_END_DATE_CHANGE were not triggered when updated the date via input
… is empty / deleted - Better safeguard for inputDateParse / inputDateFormat when date is empty (prevent Invalid Date)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
I'm coming with another pull request, this time fixing the date picker components (Date Picker and its parent, Date Range Picker).
More specifically, there are two bugs in the current copoment:
dateChange.coreui.date-pickernever triggers due to a typo in the calendar selector (.calendar instead of .calendars)This also affects Date Range Picker, because an EVENT_INPUT does NOT trigger an EVENT_START_DATE_CHANGE (_startInput) or an EVENT_END_DATE_CHANGE (_endInput)
I fixed both bugs. I also rearchitectured a bit the Date Picker to listen to the EVENT_START_DATE_CHANGE triggered on the Date Range Picker it extends from and not the one from the Calendar, in order to capture also input events, as I said earlier.
Regards,
Vlad