Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula update for Izhikevich_2007 Example #1485

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

DHRUVJ2003
Copy link
Contributor

This pr is regarding issue #1476 .I have updated the formula for Izhikevich_2007 example neuron model. Let me know if any other changes are required to be made. (This is my first contribution to brian and open source , apologies for any mistake made from my end). Thanks

@mstimberg
Copy link
Member

Thanks for the fix! Unfortunately, the fix makes the model not work anymore with the previously selected integration method (exact). I changed the method to euler so that it runs successfully. This example is a bit special, since it doesn't really matter what the neuron model does (this is why the error was in there in the first place…) – it is only used as a dummy neuron that is made to spike for each input. The interesting part of the model is the synaptic plasticity. On the good side, this means that the plot does not change with the change, so the complex stuff that I mentioned on the forum is not necessary here.

@mstimberg mstimberg merged commit 76545b0 into brian-team:master Sep 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants