Triggerspec delay unique #2893
Open
Triggerspec delay unique #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `changed` trigger modifier can see different event targets, either due to the `from` modifier or event bubbling. The existing behavior trigger only for one node (`from` modifier) or inconsistently (bubbling). Use a nested weak map to keep track of the last value per distinguished (trigger specification, event target node) pair. The weak map ensures that Garbage Collection can still recycle the nodes. If a event target was not seen via `from`, it is assumed changed for the first time the trigger is hit.
4 tasks
|
Hey, you'll want to retarget to |
It was, stupid GitHub UI always chooses the wrong base here. |
|
Thanks! Note: I'm labelling this as "under discussion" until #2891 is processed, as the latter includes some changes that this PR depends on. |
Telroshan
added
under discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a node has multiple trigger specifications, they should have independent delays. If a single delayed trigger specification is targets multiple nodes, they should share the delay.
Corresponding issue: #2892
Testing
Both variants are explicitly tested. The non-sharing of multiple trigger specifications failed before.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeededNote: the change is on top of #2891