Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utakaze] Result対応 #468

Merged
merged 3 commits into from
May 25, 2021
Merged

Conversation

blhsrwznrghfzpr
Copy link
Contributor

#423 の「小さな勇者のRPG ウタカゼ」の対応です。

ウタカゼの行為判定コマンドは成功レベル(成功度や達成値のようなもの)を求めるコマンドですが、
通常の判定では単に成功/失敗だけを確認することが多いので、
難易度指定なしの場合でも成功レベルがあればsuccessとして扱っています

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #468 (5e27237) into master (7c0b4e7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
- Coverage   95.26%   95.26%   -0.01%     
==========================================
  Files         290      290              
  Lines       18783    18780       -3     
==========================================
- Hits        17893    17890       -3     
  Misses        890      890              
Impacted Files Coverage Δ
lib/bcdice/game_system/Utakaze.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0b4e7...5e27237. Read the comment docs.

目標値なしの場合は、単に成功/失敗だけを見る場合もあるので、成功レベルに関係なく成功として扱っている
Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@ysakasin ysakasin merged commit 3b10975 into bcdice:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants