Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrinitySeven] リファクタリングおよびResult対応 #438

Merged
merged 4 commits into from
Apr 30, 2021

Conversation

blhsrwznrghfzpr
Copy link
Contributor

@blhsrwznrghfzpr blhsrwznrghfzpr commented Apr 29, 2021

#423 トリニティセブンの対応


変更内容

  • ヘルプメッセージの修正
  • Command::Parserの利用
  • 出力結果を他のシステムに似た形式に
  • ダメージコマンドのロール結果をソートするように
  • 名前表にDiceTableを使用

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #438 (130836e) into master (20b9e89) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   95.21%   95.23%   +0.01%     
==========================================
  Files         288      288              
  Lines       18698    18692       -6     
==========================================
- Hits        17803    17801       -2     
+ Misses        895      891       -4     
Impacted Files Coverage Δ
lib/bcdice/game_system/TrinitySeven.rb 100.00% <100.00%> (+2.46%) ⬆️
lib/bcdice/command/parser.rb 92.65% <0.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b9e89...130836e. Read the comment docs.

@ysakasin ysakasin merged commit 6313e58 into bcdice:master Apr 30, 2021
@ysakasin
Copy link
Member

ありがとうございます。マージしました。

@blhsrwznrghfzpr blhsrwznrghfzpr deleted the trinity_seven_result branch April 30, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants