[AnimaAnimus]Result対応 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 95.20% 95.21% +0.01%
==========================================
Files 288 288
Lines 18650 18692 +42
==========================================
+ Hits 17755 17797 +42
Misses 895 895
Continue to review full report at Codecov.
|
ysakasin
requested changes
Apr 28, 2021
| return roll_tables(command, TABLES) | ||
| else | ||
| return check_action(/(\d+)AN<=(\d+([+\-]\d+)*)/i.match(command)) |
There was a problem hiding this comment.
/(\d+)AN<=(\d+([+\-]\d+)*)/i にマッチしなかった場合 check_action() の引数がnilとなってしまい実行時エラーが発生してしまいます。
ysakasin
approved these changes
Apr 28, 2021
|
ありがとうございます。マージしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#423 のResult対応をしました。
Regexp.last_matchの削除とArithmeticEvaluator.evalからArithmetic.evalへの変更も行いました。